2006 Player | Progress Bar & Other Issues
777Sev777 opened this issue · comments
A clear and concise description of what the bug is.
Hi, got a small bug report. I'm not sure if the 2006 player theme is fully complete or still being worked on so i thought i'd submit this in case you were not already aware of it. the rest of the layouts looks and work great as always but the 2006 layout is pretty bugged out which can be seen in the screen shot.
If applicable, add screenshots to help explain your problem.
What should actually happen instead of the issue.
I assume this is what the player should actually look like:
Steps to reproduce the behavior.
im not 100% sure if this is a issue on my end or if this is reproducible or a recurring issue for other users
PlayerTube settings. (Can be found under "Import, Copy, or Reset Settings")
{
"autoplayButton": false,
"controlsBack": null,
"customTheme": true,
"darkMode": false,
"embedOtherVideos": true,
"endScreenToggle": true,
"fakeBarToggle": true,
"fullyExtendBar": false,
"heatMapToggle": true,
"progressBarBgColor": null,
"progressBarColor": "#ff0000",
"scrubberHeight": null,
"scrubberIcon": null,
"scrubberIconHover": null,
"scrubberLeft": null,
"scrubberPosition": null,
"scrubberSize": null,
"scrubberTop": null,
"scrubberWidth": null,
"settingsBgColor": null,
"showReleaseNotes": true,
"toggleFadeOut": false,
"toggleInfoCards": true,
"togglePaidContent": false,
"toggleRoundedCorners": false,
"toggleWatermark": true,
"volumeSliderBack": null,
"year": "2006"
}
Browser / Extension information.
The only extensions for youtube i use are CustomTube and some custom CSS scripts i made that dont effect the actual youtube watch page elements like the player etc used with this extension.
Since you're using CustomTube, make sure you have your CustomTube settings set to what is in this screenshot: https://github.com/ktg5/PlayerTube/blob/main/img/customtube-settings.png (which was displayed in the release notes/update page when PlayerTube updates)
But I haven't seen an issue like this yet. Unsure what else it could be if it's not CustomTube messing with it.
Any update on this?
Little late to this. I tested it out on Firefox and Microsoft Edge, with and without CustomTube. I fiddled with the settings, tried disabling CustomTube, reinstalled both extensions, and even tried different screen resolutions, but it seems to just be a general issue with the style, which is weird considering the other styles work perfectly. (the gap is a completely separate issue from customtube)
yeah I've come to the same conclusion after messing around with and testing with and without custom tube etc. its def not an issue with customtube compatibility. not sure specifically what would be causing it specifically, the rest of the styles work perfect so im not sure if its a problem in the CSS but im glad to learn im not the only one experiencing this issue.
Seems to be multiple variations of issues with this theme, unsure if I'll be able to get each one fixed. But I'm working on fixing all of this right now.
Sending out a new version of PlayerTube right now that should fix these issues. The reason for some stuff not moving is that the moving elements part of the 2006 theme script was looking for an element that isn't in vanilla YouTube (sorry about that lol).
You can find how to install the latest beta build here.
It works, but now its flickering
I think I know what you mean -- does the Progress Bar change sizes very quickly?
The issue seems to now be with CustomTube and Firefox. When CustomTube was on with both browsers, the resizing effect continues, same as the previous screenshots. On Microsoft Edge, the resizing effect does not happen at all, with or without theater mode enabled. However, on Firefox, it continues to happen outside of theater mode, albeit more minuscule.
It keeps showing up.
2024-01-16.18-10-58.mp4
The issue seems to now be with CustomTube and Firefox. When CustomTube was on with both browsers, the resizing effect continues, same as the previous screenshots. On Microsoft Edge, the resizing effect does not happen at all, with or without theater mode enabled. However, on Firefox, it continues to happen outside of theater mode, albeit more minuscule.
Can't seem to replicate any of the issues described here
It keeps showing up.
2024-01-16.18-10-58.mp4
Will be fixing this.
New fix on the Actions page that could fix everything up to this point.
If there are more issues, send them in with good detail.
new update fixed the general layout and placement of the player, but just like in the video above I am getting strange flickering when interacting with it. looking at stuff on my end can't really tell why it's happening. granted I haven't really looked at all the code so I don't quite know the inner workings of the extension, but I can say for certain that it isn't a custom tube or conflict issue. something is trying to force the progress bar to extend fully across the player.
I don't know what else to say. On my side, everything works fine. If you wanna look through the code, be my guest, the resize code for PlayerTube can be found here. I put as many comments around my code as I can, so it should be easy to understand.
But generally, the math for the Progress Bar uses (the video's width) - (whatever offset, which is currently 56) - (the size of the right controls)
The reason for most of the Progress Bar's past glitching is due to the fact that YouTube's website has another hidden script (love these!) which turns some buttons to display: none if the right controls get to a current size. After the recent update, it works fine for me, but I'm unsure what else could be causing problems when I'm not having any issues on my side.
I don't know what else to say. On my side, everything works fine. If you wanna look through the code, be my guest, the resize code for PlayerTube can be found here. I put as many comments around my code as I can, so it should be easy to understand.
But generally, the math for the Progress Bar uses (the video's width) - (whatever offset, which is currently 56) - (the size of the right controls) The reason for most of the Progress Bar's past glitching is due to the fact that YouTube's website has another hidden script (love these!) which turns some buttons to
display: noneif the right controls get to a current size. After the recent update, it works fine for me, but I'm unsure what else could be causing problems when I'm not having any issues on my side.
yeah i understand, and true youtube is really weird sometimes with custom scripts and extensions. ill poke around a bit. regardless this is one of my fav extensions for yt. and you have done a great job recreating stuff, keep up the great work and thank you for making it public. cant wait for more updates.
Putting this as resolved for now, feel free to open another issue if anything new pops up