Old Loading Spinner and Progress Bar Issue
OleExploder opened this issue · comments
I really like using this fantastic extension with the old video player but I think it is missing the old loading spinner and the progress bar does not go all the way to the end like it is supposed to so can you please fix those two things if you can and whenever you have a chance?
I haven't got to find the asset for the old loading spinner, but it is definitely something that will be added.
For the progress bar issue, can you send over your browser information & PlayerTube config? (Also provide a screenshot if possible)
The actual browser I am currently using is Vivaldi, I only enabled "Fully extend the Progress Bar's height at all times" but other than that every setting is default from when I installed it and here is a screenshot of the progress bar error I am talking about.
Ah, I see what you're talking about.
This was a fix for an issue back in the days when this extension was a user script (under the name, YT-HTML5-Player), although at the end of videos, that little thing at the end is supposed to be whatever color the main progress bar color is.
Anyway, the script on YouTube's site changes the size of the progress bar with a width value, changing it every pixel. I don't know where in the code it does it, but it's somewhere there. Making some simple CSS changes won't do, as I've already tried everything I could do with CSS, but it has resulted to what it is today. Won't fix, for now.
But, I've added the loading spinner that you originally requested, it's up as of now on the GitHub repo, and you can install it by following this link here.
I just installed the new build of this that supposedly has the old loading spinner but unfortunately I still saw the new loading spinner for some reason.
Oh, probably because the CSS loads before the video is done buffering. Will fix this soon.
Alright, thank you.