kshedden / gonpy

Read and write Numpy binary files (.npy files) in Golang

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix API NewWriter api to receive io.Writer and not a filename

dakerfp opened this issue · comments

Making this, conforms the API as the other examples in the standard library.

Thanks for the comment. I agree the naming is unconventional but changing it would involve a compatibility break (the requested functionality is already present under names ReaderFromStream and WriterFromStream).

At this point, I added more conventional alternative names NewFileWriter and NewFileReader and marked NewReader and NewWriter for possible incompatible changes in the future.

I updated the API so that the names are more conventional, as suggested above.