Giters

kryptek / pagerduty-sdk

A Ruby SDK for Pagerduty's API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

net-http >ruby 1.9.3 seems required

dfarrell-bloom opened this issue · comments

commented

got a net-http error when using 1.9.3:

/Users/dfarrell/.rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/net/http.rb:1861:in `initialize': undefined method `empty?' for #<URI::HTTPS:0x007f93e19223a0> (NoMethodError)
    from /Users/dfarrell/.rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/net/http.rb:2094:in `initialize'
    from /Users/dfarrell/.rvm/gems/ruby-1.9.3-p484/gems/pagerduty-sdk-1.0.5/lib/pagerduty/core.rb:49:in `new'
    from /Users/dfarrell/.rvm/gems/ruby-1.9.3-p484/gems/pagerduty-sdk-1.0.5/lib/pagerduty/core.rb:49:in `curl'
    from /Users/dfarrell/.rvm/gems/ruby-1.9.3-p484/gems/pagerduty-sdk-1.0.5/lib/pagerduty/pagerduty.rb:595:in `get_log_entries'
    from incidentsearch.rb:9:in `<main>'

looks like 1.9.3 doesn't handle URI quite as intelligently:
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/net/http/rdoc/Net/HTTPGenericRequest.html#method-c-new

switching to ruby 2.1.0 seems to have fixed the problem
http://www.ruby-doc.org/stdlib-2.1.1/libdoc/net/http/rdoc/Net/HTTPGenericRequest.html#method-c-new