kristianmandrup / masonry-rails

JQuery Masonry plugin ready for use with Rails asset pipeline

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Please remove dependency on Rails.

pboling opened this issue · comments

Projects that are "rails" projects, but only load some of the parts of rails, like those that don't use ActiveRecord, do not need to load the rails gem, and shouldn't need to have it pulled into the project.

Look at the official *-rails gems (e.g. jquery-rails) and you'll see they do not depend on rails.

Part of our Gemfile:

gem 'actionpack',                 '4.1.7'
gem 'actionview',                 '4.1.7'
gem 'activesupport',              '4.1.7'
gem 'railties',                   '4.1.7'
gem 'sprockets-rails',            '~> 2.2.0', :require => 'sprockets/railtie'
gem 'sprockets',                  '~> 2.11.3'

We don't load any other bits of rails, but rails is still being pulled into our project by our dependency on masonry-rails.

Good point! I will remove the dependency shortly (b4 tmrw evening) or you can do the fix and make a pull request.

#14 👍

caveat: Untested. Not sure how I would test. Don't have time to myself! I advise a smoke test.

Released 0.2.3 without rails dep. I think/hope it should work. I don't code Ruby or Rails these days...
You are welcome to take over this gem...

Also merged your PR and published 0.2.4 :P
Do you feel lucky, PUNK!? haha...

Try your luck 👍