Backup not completing in S3 Bucket

Question

Backup not completing in S3 Bucket

jonnydubowsky opened this issue 4 years ago · comments

Hi- Thanks for creating this awesome tool!
I've been working to get it setup and running into issues.
My intention is to ultimately get this working as part of a few demonstrations I am giving on knowledge graph mapping. As such, I am planning on making the backups public, and you can check out the forked version I'm working from here:
https://github.com/totemprotocol/roam-backup/actions

I Setup the AWS s3 bucket. Setup github fork & the secret for github actions.
Successfully initiated the first Action by making a commit.
The Action successfully completed, but I do not see a completed backup in the S3 Bucket.
When referring back to the Github Action, no artifacts or annotations were created.

Here is what was generated for the workflow file:

.github/workflows/main.yml
name: "Roam Research backup"
on:
push:
```
branches:
```
```
  - master
```
schedule:
```
- cron: "*/15 * * * *"
```
jobs:
backup:
```
runs-on: ubuntu-latest
```
```
name: Backup
```
```
steps:
```
```
  - uses: actions/checkout@v2
```
```
  - uses: actions/setup-node@v1
```
```
    with:
```
```
      node-version: "10.x"
```
```
  - run: npm install
```
```
  - run: npm start
```
```
    env:
```

      ROAM_EMAIL: ${{ secrets.roamEmail }}

      ROAM_PASSWORD: ${{ secrets.roamPassword }}

      AWS_BUCKET_NAME: ${{ secrets.awsBucketName }}

      AWS_ACCESS_KEY_ID: ${{ secrets.awsAccessKeyId }}

      AWS_ACCESS_KEY_SECRET: ${{ secrets.awsAccessKeySecret }}

A few other details:

Under the S3 bucket's settings:
- Block all public access
- On
  - Block public access to buckets and objects granted through new access control lists (ACLs)
  - On
  - Block public access to buckets and objects granted through any access control lists (ACLs)
  - On
  - Block public access to buckets and objects granted through new public bucket or access point policies
  - On
  - Block public and cross-account access to buckets and objects through any public bucket or access point policies
  - On
- When I review the user level Access Adviser details, it shows that the s3 bucket has the appropriate policy enabled, but under "last access" shows "Not accessed in the tracking period"

Please let me know any other details I can provide to troubleshoot this.

Thanks!
-

Kristian Freeman · Answer 1 · Tue Mar 10 2020 04:02:31 GMT+0800 (China Standard Time)

hey @jonnydubowsky!

it looks like there is an error here - https://github.com/totemprotocol/roam-backup/runs/496115224?check_suite_focus=true#step:5:17 - it didn't make the build fail, which isn't great. i'll open a new issue for that as i think the error catching might be causing that.

as for why the selector isn't working: is it possible that you have multiple databases? that work is being tracked at #6, see this comment for some context.

if you aren't using multiple databases, this may just be a new error! let me know and we can continue to debug accordingly

Jonny Dubowsky · Answer 2 · Wed Mar 11 2020 11:49:27 GMT+0800 (China Standard Time)

Thanks for the feedback. I do have multiple databases! I'll review #6 and the comment you provided and let you know how it goes.