Allowing other models for extracting features
jinyongyoo opened this issue · comments
Jeffrey Yoo commented
Hello!
First off, thanks for sharing the code. In the paper, it says that MAUVE works with other embedding models. Therefore, I wanted to try out models such as DialoGPT from Microsoft. But in the code, it limits the model and tokenizer name to "gpt2" family. I think it would better we remove this restriction since others might also want to try out other models.
If you want, I can make a PR to change this.
Lines 25 to 39 in b3c01d5
Krishna Pillutla commented
Hi @jinyongyoo, a PR for this would be fantastic. Thanks!