Does not work with aws provider version 2.70.1
et304383 opened this issue · comments
We are stuck on version 2.x of AWS provider. When attempting to use the tool for this specific version, I get errors from what looks like failure to run bash commands:
Expected Behavior
It works!
Actual Behavior
It fails with sh line 0 errors (see below).
m1-terraform-provider-helper install hashicorp/aws -v v2.70.1
Repo: https://github.com/hashicorp/terraform-provider-aws
GitRepo: git@github.com:hashicorp/terraform-provider-aws
HEAD is now at 2ff8acfb9b Merge pull request #22396 from GlennChia/f-aws_dax_cluster
2022/01/04 10:05:22 version: v2.70.1
Cancel
sh: line 0: cd: tools: No such file or directory
2022/01/04 10:06:16 Bash code did not run successfully: exit status 1
Steps to Reproduce (including precondition)
m1-terraform-provider-helper install hashicorp/aws -v v2.70.1
Your Environment
- OS: 12.1
- m1-terraform-provider-helper version: 0.2.4
Thanks for reporting! I already have an idea where this bug is originating from, will verify in the upcoming days and provide a fix :)
@et304383 I managed to find the error and fix it locally. But I came across another problem: According to the documentation of the provider (https://github.com/hashicorp/terraform-provider-aws/blob/v2.70.1/docs/DEVELOPMENT.md) you have to run make tools && make build in order to build the provider.
But this does not work for me, it complains about non compliant gofmt.
I actually have to run make tools && make fmt && gofmt -s -w ./tools.go && make build so that it compiles correctly.
Can you verify that
make tools && make builddoes not workmake tools && make fmt && gofmt -s -w ./tools.go && make buildworks?
Thanks a lot!