Doesn't work with Sidekiq 3.0
opened this issue · comments
Bundler could not find compatible versions for gem "sidekiq":
In Gemfile:
sidekiq-middleware (>= 0) ruby depends on
sidekiq (< 3, >= 2.12.4) ruby
sidekiq (3.0.0)
Thanks!
Hey, thanks for reporting. Tests are passing with sidekiq master branch, so I've removed version constraint.
Thanks!
Doh, you should probably add that version constraint back in... I'm about to break the client middleware API.
Yeah, just tried it and ending up with an "ArgumentError: wrong number of arguments (4 for 3)" at lib/sidekiq-middleware/client/unique_jobs.rb:5: when submitting jobs.
Too bad..
Just released a 0.3.0
which is compatible with both Sidekiq 2 and 3.
hey @krasnoukhov is the java version different? I can't get it to work with 2.x
sidekiq-middleware (~> 0.3) java depends on
sidekiq (3.0.0)
Hey @kenips, there is no difference between Ruby platforms, since sidekiq-middleware is pure Ruby.
Just managed to get bundle installed on JRuby 1.7.10, here is my setup: https://gist.github.com/krasnoukhov/10378930
Can you show your Gemfile/Gemfile.lock if problem still persists? Thanks.
I see. Here's mine:
gem 'sidekiq'
gem 'sidekiq-status', "~> 0.4"
gem 'sidekiq-middleware', "~> 0.3"
And when I bundle here's what I get:
Bundler could not find compatible versions for gem "sidekiq":
In Gemfile:
sidekiq-status (~> 0.4) java depends on
sidekiq (~> 2.7) java
sidekiq-middleware (~> 0.3) java depends on
sidekiq (3.0.0)
and hence I jumped on sidekiq-middleware being the problem. Looking at sidekiq-status's gemspec I don't see anything wrong either.
Here's the full bundler output. I'm going to open a bug on their side and see if I get some explanation.
Hey @krasnoukhov I got it figured out. Bundler bug indeed but fixed in 1.6. Thanks for looking into it!
Awesome, @kenips 👍