[BUG] Deleting a task with child nodes crashes
trag1c opened this issue ยท comments
Describe the bug ๐
When creating a task with child nodes, trying to remove the parent task results in a crash. The task does get deleted successfully though.
To Reproduce ๐ฃ
Steps to reproduce the behavior:
- Create a task
foo
- Add a child task
bar
to it - Try removing task
foo
(xx
) - See error
Desktop (please complete the following information): ๐ค
- OS: macOS
- Version: 14.2.1
Additional context ๐
โญโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ Traceback (most recent call last) โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฎ
โ /Users/trag1c/.local/pipx/venvs/dooit/lib/python3.12/site-packages/textual/app.py:3271 in _on_notify โ
โ โ
โ 3268 โ โ
โ 3269 โ def _on_notify(self, event: Notify) -> None: โ
โ 3270 โ โ """Handle notification message.""" โ
โ โฑ 3271 โ โ self._notifications.add(event.notification) โ
โ 3272 โ โ self._refresh_notifications() โ
โ 3273 โ โ
โ 3274 โ def _unnotify(self, notification: Notification, refresh: bool = True) -> None: โ
โ โ
โ โญโโโโโโโโโโโโโโโโโโโโโโโ locals โโโโโโโโโโโโโโโโโโโโโโโโฎ โ
โ โ event = Notify() โ โ
โ โ self = Dooit(title='Dooit', classes={'-dark-mode'}) โ โ
โ โฐโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฏ โ
โฐโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฏ
AttributeError: 'Notify' object has no attribute 'notification'
Hmm .. I thought this was fixed in dev but maybe not
Pushing a fix!
Thanks for opening an issue!
Should be fixed in the latest release! Can you re-check?
Thanks
I'm closing this for now. Feel free to reopen if the problem still persists
Thank you โค๏ธ
Did we solve your problem?
Glad we could help!
Consider sponsoring my work through github sponsors ๐
โ @kraanzu
Hey I forgot to check, sorry ๐ The problem is indeed fixed, thanks!