Giters

kornia / kornia-rs

Low-level Computer Vision library in Rust

Home Page:https://docs.rs/kornia-rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

use `thiserror` to handle errors

edgarriba opened this issue · comments

commented

for now errors are handle with anyhow -- this is good at application level but ideally we should create custom error types for lib development.

ideally use https://github.com/dtolnay/thiserror

commented

Hi @edgarriba I am interested in contributing to this project. How do I get started?

commented

@vcode11 thanks for the interest ! if you feel comfortable with Rust and thiserror feel free to go for it

commented

I found your commit: d72fca8 this seems to solve the problem? Any particular reason why you didn't merge this? Anything that is missing here that you would like to have?

commented

lack of time to finally land this but feel free to take that diff resume the task. The only thing i was a bit concerned is that i couldn't figure out properly how to chain all the original errors for the integrated library a propagate properly to the high level applications.