Legacy JS support removed - intentional?
jpd236 opened this issue · comments
klock 2.1.1 appears to no longer include support for Kotlin/JS's legacy compiler. I'm guessing this is due to this commit:
korlibs/easy-kotlin-mpp-gradle-plugin@f84b257
I wanted to ask what the reasoning was behind this change. My project (https://github.com/jpd236/kotwords) still uses the legacy compiler; the IR compiler is still pretty rough around the edges from my testing - it's explicitly marked as an alpha in the official docs - and doesn't seem to be a trivial change. The docs here recommend that libraries compile to both. Wouldn't it make sense here to release both versions until IR becomes more stable and prevalent?
I removed it intentionally. But I can enable it again.
Regarding to the reasoning: I believed that in 1.5, IR was recommended for all the targets. But reading the documentation you linked, it seems to not be the case, so I believe it make sense to enable BOTH again.
I will try to enable it in the next release
In theory if everything goes well 0.15.3 should include BOTH artifacts: https://github.com/korlibs/klock/actions/runs/874689849
I'm closing the issue. Feel free to reopen if you find some issues with this
It seems that at least 2.3.1 does not contain the legacy version. At least Gradle is complaining in my project.
It seems that 2.2.2 contains the version for legacy backend, 2.3.0 is the fist version without
@jschneider no new additions on 2.3.0. The release is there because was triggered in korge-next for a consistent release to save me time on releases:
https://github.com/korlibs/korge-next
You can safely use 2.2.2 that should be binary compatible with all Kotlin 1.5.x versions.