koraykv / unsup

Some unsupervised learning modules using Torch

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

zca_whiten is using :resize instead of :view

soumith opened this issue · comments

at several places, zca_whiten is using :resize, while this works in practice, the correct way would be :view or :reshape as :resize by definition can be destructive when it wants to.

sure, pr? :)

Fixed in c69ae3f
Verified that that zca unit tests pass.