kookster / activemessaging

ActiveMessaging moved from google code - this will be the latest and greatest

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stopping poller sends unsubscribe message even for durable subscriber

onyx opened this issue · comments

commented

We are using activemessaging gem version 0.9.0. We use poller to start and stop the subscriber. We have durable subscriber and when we stop the poller, gem sends UNSUBSCRIBE command to activemq in addition to DISCONNECT command.

We do not want to unsubscribe as subscriber is durable and if it is no longer subscribed, it will loose any message which came on the topic while it was offline.

Do you think this feature is reasonable and, if yes, we could work to provide a patch to add an option to avoid unsubscribing.

I think the idea is that if the poller dies/crashes then it would not unsub, and you would have continuity, but if you stop it, then it should unsub. How would you differentiate between when you want a poller to unsub, and when not?