kokuwaio / helm-maven-plugin

Simple plugin to package helm charts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

helmHomeDirectory is not supported yet?

NancyChunlan opened this issue · comments

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Bug Report

What happened:

After upgrade to helm-maven-plugin 5.x. helmHomeDirectory is not supported. and the default user HELM_HOME is used.
But helm init is not executed by default, which lead to helm add repo failed.
And the README.md is still with description about this helmHomeDirectory.

What you expected to happen:

  1. Helm init for user HELM_HOME may need to be executed with configuration.
  2. Or to add back helmHomeDirectory

How to reproduce it (as minimally and precisely as possible):

delete .helm/repository and use this plugin to exeucte mvn helm:init

Anything else we need to know:
After check the git log, the removal of helmHomeDirectory is in following commit.

commit 3763889b32169d00c2bf980bd1a3dc9ba7ca2e36
Author: Axel Köhler <koehler.ax3l@gmail.com>
Date:   Fri Nov 29 21:26:11 2019 +0100

    Migrate to Helm3

You can use helm.executableDirectory for this. Please comment if this does not work. Tested with 6.x.x