Not building against kodi 18
davidheitman opened this issue · comments
I'm encountering multiple issues with building against the latest kodi 18 branch. First issue is:
CMake Error at /home/loucipher/repos/Lou-Cipher/xbmc/kodi-addon/build/depends/lib/kodi/AddonHelpers.cmake:192 (message):
"@ADDON_DEPENDS@" not found in addon.xml.in.
Call Stack (most recent call first):
CMakeLists.txt:22 (build_addon)
-- Configuring incomplete, errors occurred!
Which can simply (and possibly incorrectly) be fixed by adding said line to addon.xml.in (see my branch at https://github.com/Lou-Cipher/peripheral.xarcade/tree/addon_depends). The second issue, changes in same branch, is paths to headers in the include statements. Easy fix. The last problem, which may be related to my hasty patch of the first (not sure, haven't had time to investigate yet), is the following build error:
[ 80%] Building CXX object CMakeFiles/peripheral.xarcade.dir/src/addon.cpp.o
/home/loucipher/repos/Lou-Cipher/xbmc/kodi-addon/build/peripheral.xarcade/src/addon.cpp:92:32: error: ‘ADDON_StructSetting’ was not declared in this scope
unsigned int ADDON_GetSettings(ADDON_StructSetting*** sSet)
^~~~~~~~~~~~~~~~~~~
/home/loucipher/repos/Lou-Cipher/xbmc/kodi-addon/build/peripheral.xarcade/src/addon.cpp:92:32: note: suggested alternative: ‘ADDON_SetSetting’
unsigned int ADDON_GetSettings(ADDON_StructSetting*** sSet)
^~~~~~~~~~~~~~~~~~~
ADDON_SetSetting
/home/loucipher/repos/Lou-Cipher/xbmc/kodi-addon/build/peripheral.xarcade/src/addon.cpp:92:55: error: ‘sSet’ was not declared in this scope
unsigned int ADDON_GetSettings(ADDON_StructSetting*** sSet)
^~~~
CMakeFiles/peripheral.xarcade.dir/build.make:134: recipe for target 'CMakeFiles/peripheral.xarcade.dir/src/addon.cpp.o' failed
make[5]: *** [CMakeFiles/peripheral.xarcade.dir/src/addon.cpp.o] Error 1
make[5]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:99: recipe for target 'CMakeFiles/peripheral.xarcade.dir/all' failed
make[4]: *** [CMakeFiles/peripheral.xarcade.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make[3]: *** [all] Error 2
CMakeFiles/peripheral.xarcade.dir/build.make:112: recipe for target 'peripheral.xarcade-prefix/src/peripheral.xarcade-stamp/peripheral.xarcade-build' failed
make[2]: *** [peripheral.xarcade-prefix/src/peripheral.xarcade-stamp/peripheral.xarcade-build] Error 2
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/peripheral.xarcade.dir/all' failed
make[1]: *** [CMakeFiles/peripheral.xarcade.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
This should be fixed with #3