Giters

koddsson / coworking-with

👩🏻‍💻 Easily add coworking signitures to your commits.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Author confirmation is lost

muan opened this issue · comments

commented

Added in #9, removed in #16. Not sure if this was intentionally, but I personally would still like a confirmation so that I know which user the script found.

commented

Ah, I removed it since I thought the script was too verbose. I don't mind adding it back but I might hide it behind a log level in the future.

commented

That'd be great. I'd be happy to pass -v.

I think I want the confirmation because I don't fully trust the script to get me what I want reliably.

For example, before github user fetch was properly supported, I do david to get David Graham in git log because his email does not contain the string dgraham, but it doesn't always work because there can be multiple davids. At the same time, if you work with someone with a short github username, like mdo, you'll get the first git log match, which could be Ben Emdon, or it could be mdo@github.com, then I have to cat .git/config to confirm.

Perhaps this can be improved with a source flag? which will definitely let me trust the script more. coworking-with mdo --gh or something.