compress = true ignored when below treshold

[Jesper]

Although docs says

You can always enable compression by setting this.compress = true

Mistake in docs or code? :)

[jongleberry]

It should ignore threshold. Does it not?

[Jesper]

no, this.compress is not checked

if (threshold && this.response.length < threshold) return

https://github.com/koajs/compress/blob/master/index.js#L63

[Jeremiah Senkpiel]

@jesperp see https://github.com/koajs/compress/blob/master/index.js#L55
and https://github.com/koajs/compress/blob/master/index.js#L44

this.compress does not force compression below the threshold. It merely bypasses the filter, or enables on a file-by-file level.

[Jesper]

gotcha

[Jeremiah Senkpiel]

@jesperp Apologies, let me correct myself, that should have been below the threshold.

i.e. the threshold is for files that are too small to bother with.