Unexpected identifier - `of`

Question

Unexpected identifier - `of`

vjpr opened this issue 9 years ago · comments

Vaughan Rouesnel commented 9 years ago

This makes Node v4 a requirement which is not mentioned anywhere.

Shame to break Node 0.12.x support for such a minor syntax change, seeing as Koa@2 supports 0.12.x.

Xin Hao · Answer 1 · Sat Dec 19 2015 23:28:38 GMT+0800 (China Standard Time)

koa@2 requires node@4+

Blake Embrey · Answer 2 · Tue Apr 05 2016 09:35:11 GMT+0800 (China Standard Time)

@coderhaoxin Would you consider making the changes to just koa-compose? It'd be a bummer to duplicate all the code when it'd be nice just to re-use this library for arbitrary (non-Koa specific) async middleware.

Xin Hao · Answer 3 · Tue Apr 05 2016 09:53:25 GMT+0800 (China Standard Time)

Would you consider making the changes to just koa-compose?

@blakeembrey I don't know what you meant. :) 😢

Blake Embrey · Answer 4 · Tue Apr 05 2016 11:12:38 GMT+0800 (China Standard Time)

This module is koa-compose, not koa. Would you consider making the code here ES5 instead of ES6 so that node <= 0.12 can use it? I'd like to use the module without replicating it for my own uses.

Xin Hao · Answer 5 · Tue Apr 05 2016 11:32:40 GMT+0800 (China Standard Time)

@jonathanong we need change for of to normal for loop!

Should we add node <= 0.12 to the travis ?

Blake Embrey · Answer 6 · Tue Apr 05 2016 11:43:23 GMT+0800 (China Standard Time)

Thanks! The only other piece is the const. I'd love if you could test down to 0.10 too.

Blake Embrey · Answer 7 · Tue Apr 05 2016 12:09:12 GMT+0800 (China Standard Time)

For reference, I want to use it for a HTTP request library (serviejs/popsicle#49) and have written a corresponding type definition (https://github.com/typed-typings/npm-koa-compose/blob/master/index.d.ts) in case you're interested in supporting TypeScript users in the module.