koajs / compose

Middleware composition utility

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Octal literals are not allowed in strict mode.

hemanth opened this issue · comments

I happened to run an example with --strict-mode and noticed a syntax error, well I'm not sure if compose is even bothered about strict mode, the issue is with those console.log statements which is highlighting strings.

@visionmedia would you accept pull request to fix those issues? Without --strict-mode we can't use many of --harmony features. I'm going to use colors.js as a replacement - it seems to be working just fine in strict mode. I can make similar pull requests for other koa dependency libraries. Please let me know. Thank you.

@serge-z PR's on me if it's a yes from @visionmedia 😄 I shall not use colors.js but shall use chalk 🌵 deal?

Sure, thank you for mentioning chalk :)

removed instrumentation anyway

👍
On Apr 29, 2014 10:08 AM, "TJ Holowaychuk" notifications@github.com wrote:

removed instrumentation anyway


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-41641036
.