A11Y error due to tabindex > 0

Question

A11Y error due to tabindex > 0

Willibaur opened this issue 6 years ago · comments

Thanks for this awesome addon.

Below you will see an A11Y error related, it was catched by ember-A11Y-testing it seems an easy one to fix on 👉 x-toggle/component.js

I'm happy to create a PR if you agree this should be tabindex: '0'.

Thanks

Ilya Radchenko · Answer 1 · Sat Oct 06 2018 03:15:16 GMT+0800 (China Standard Time)

Could probably just remove the tabindex all together and users can apply those as needed.

William Bautista · Answer 2 · Mon Oct 08 2018 14:52:18 GMT+0800 (China Standard Time)

I'm not sure, as a general A11Y rule, it should be tabindex: 0, so what about to set it to that value by default within the addon, but give the option to the user to modify as required @knownasilya like we do with offLabel property ?

Ilya Radchenko · Answer 3 · Tue Oct 09 2018 04:21:19 GMT+0800 (China Standard Time)

The user can already set it, e.g. {{x-toggle tabindex='0'}}

Ilya Radchenko · Answer 4 · Tue Oct 09 2018 04:22:07 GMT+0800 (China Standard Time)

I'll change it to '0'

William Bautista · Answer 5 · Tue Oct 09 2018 16:04:09 GMT+0800 (China Standard Time)

Thanks for the fix @knownasilya

Ilya Radchenko · Answer 6 · Fri Oct 12 2018 06:59:55 GMT+0800 (China Standard Time)

Released in 5.3.1