kniklas / get-fx

Get FX is tool to download average FX rates from National Bank of Poland (NBP)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add proxy option

kniklas opened this issue · comments

Enable proxy connectivity using option or configuration file (see #10).

Please note that according to the requests docs (https://docs.python-requests.org/en/master/user/advanced/#proxies), the library supports standard env variables, like HTTP_PROXY, HTTPS_PROXY, etc.
This should probably be tested. If it works, then in my opinion adding any other specific method of configuring the proxy is unnecessary, as those environment variables are definitely standard across lots of different software products.

Thank you @binarysailor ! Definitely I will check this out when I work on this item.
I have found this probably will work well under windows: https://stackoverflow.com/a/8287752 (TBC)

Good news! Adding http_proxy or https_proxy under windows works with GetFX. I will close this issue once I update the documentation! Thank you @binarysailor

Addressed in pull request #18