knative / observability

I believe most knative repos are using "kubernetes-1.12.6" for their k8s.io dependencies. It looks like observability is not (e.g.,

observability/go.mod

Line 38 in 94718bb

k8s.io/client-go v10.0.0+incompatible

)

The following should not result in a diff:

for repo in $(cat go.mod | egrep '^\s+k8s.io' | awk '{print $1}'); do 
  go get $repo@kubernetes-1.12.6
done

After doing so, it looks like there are compile errors:

$ go test ./...
# github.com/knative/observability/pkg/client/clientset/versioned/typed/sink/v1alpha1/fake
pkg/client/clientset/versioned/typed/sink/v1alpha1/fake/fake_clusterlogsink.go:134:44: too many arguments in call to testing.NewPatchSubresourceAction
	have (schema.GroupVersionResource, string, string, types.PatchType, []byte, []string...)
	want (schema.GroupVersionResource, string, string, []byte, ...string)
pkg/client/clientset/versioned/typed/sink/v1alpha1/fake/fake_clustermetricsink.go:134:44: too many arguments in call to testing.NewPatchSubresourceAction
	have (schema.GroupVersionResource, string, string, types.PatchType, []byte, []string...)
	want (schema.GroupVersionResource, string, string, []byte, ...string)
pkg/client/clientset/versioned/typed/sink/v1alpha1/fake/fake_logsink.go:134:44: too many arguments in call to testing.NewPatchSubresourceAction
	have (schema.GroupVersionResource, string, string, types.PatchType, []byte, []string...)
	want (schema.GroupVersionResource, string, string, []byte, ...string)
pkg/client/clientset/versioned/typed/sink/v1alpha1/fake/fake_metricsink.go:134:44: too many arguments in call to testing.NewPatchSubresourceAction
	have (schema.GroupVersionResource, string, string, types.PatchType, []byte, []string...)
	want (schema.GroupVersionResource, string, string, []byte, ...string)

As mentioned in issue #35, we are working to get this working with go modules which requires updating all the dependencies. I think this may be the way to go but we haven't "bitten the bullet" yet in updating all our dependencies.

It looks like k8s.io/code-generator still needs to be edcfb81a444e5a0f0c799893e4c246ed7b9a3a3a as k8s.io/apimachinery does not have scheme.Codecs.WithoutConversion(). So to revise my previous for-loop:

for repo in $(cat go.mod | egrep '^\s+k8s.io' | awk '{print $1}'); do 
  go get $repo@kubernetes-1.12.6
done
go get k8s.io/code-generator@edcfb81a444e5a0f0c799893e4c246ed7b9a3a3a

k8s.io deps are out of sync with the rest of knative