knative / client-contrib

Community contributed `kn` plugins.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Common code across plugins

maximilien opened this issue · comments

For kn-source-kafka and kn-source-github and various planned plugins, @daisy-ycguo and I have a common set of code we use as kn-source-pkg. We would like to have this here.

While kn-source-pkg is structured like a plugin, it is not. So putting it in this repo’s plugins directory would not be correct. So I am suggesting we create a top level lib directory (like we did for client and put it there. This could also serve for a good place for other such common code.

Thoughts? Please respond soon. I will leave this open after Thursday like the other recent global issues for this repo.

@daisy-ycguo, @rhuss, @navidshaikh See ^^^

Please comment if you have different suggestions or opinions. Thursday’s TOC will also help in case we decide something different.

This is duplicate to #56 since that same repo should contain all common code. So closing this.