Giters

knative / client-contrib

Community contributed `kn` plugins.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[discussion] how to setup clueters for e2e testing properly

xliuxu opened this issue · comments

commented

Currently we have e2e test entrypoint in test/e2e-tests.sh, and it will iterate over all plugin directories to find and execute e2e test scripts. Based on such settings I have the following questions:

  1. Do we have necessary permissions to create clusters in GKE as the same of knative/client?
  2. Does every plugin need to set up clusters for its own and do teardown afterwards or to share the same cluster instead?
commented

Currently we have e2e test entrypoint in test/e2e-tests.sh, and it will iterate over all plugin directories to find and execute e2e test scripts. Based on such settings I have the following questions:

  1. Do we have necessary permissions to create clusters in GKE as the same of knative/client?

Yes, but we don't need to bother. The e2e test framework will do that for us.

  1. Does every plugin need to set up clusters for its own and do teardown afterwards or to share the same cluster instead?

Knative install and client install are handled by the common test infrastructure. Every plugin need to set up the necessary resources for that plugin specific test. For example, the source-kafka plugin has to set up kafka cluster for its e2e test. Refer to the e2e-tests.sh in kafka plugin.

commented

Cool. Thanks for the clairification. @daisy-ycguo