As knative admin, I want to list custom domains
ZhuangYuZY opened this issue · comments
Now we have kn admin domain set to set custom-domain. But we are missing a list command to show custom domains.
List Knative custom domain
Usage:
kn admin domain list [flags]
Examples:
# To list all custom domains
kn admin domain list
Flags:
-h, --help help for list
--no-headers When using the default output format, don't print headers (default: print headers).
Global Flags:
--config string config file (default is $HOME/.config/kn/plugins/admin.yaml)
@zhanggbj Based on our talk, there is pkg for format output. Could you please give a reference to implement domain list ? Thank you
/assign
I also work on this new command.
@ZhuangYuZY
As kn-admin is a plugin of kn client, I think it's good to align with kn client, althrough there're some common go pkg for printer.
- Here is the pkg from kn client "knative.dev/client/pkg/printers"
- We can refer to route list here
One concern from my side, if we're going to list all, I think there's no need to specify flags --custom-domain any more.
I remove the --custom-domain flag. Thank you.