knative / client-contrib

Community contributed `kn` plugins.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

As knative admin, I want to unset custom domain

ZhuangYuZY opened this issue · comments

Now we have kn admin domain set to set custom-domain. But we are missing to unset the custom domain if it is not used or incorrect.

unset Knative route domain for service

For example:
# To unset a route domain
kn admin domain unset --custom-domain mydomain.com

Usage:
  kn admin domain unset [flags]

Flags:
  -d, --custom-domain string  Custom domain to unset
  -h, --help                   help for unset

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)

/assign
I would work on this new command.

Function code is ready, now I am waiting on #14, then add test for unset. Thank you.

PR submitted, #38

PR merged, closing...