knative-extensions / security-guard

Runtime security plug to protect user containers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

v1alpha1_test improvements needed

davidhadas opened this issue · comments

v1alpha1_test.go

  • Explain the permutations - clarify what each test does
  • Move away from permutations in which output is not tested such as .String(9) without testing the output? - check the output value; ensure all tests are both focused and the output is tested.
  • Consider the tests in the context of go test - for example, go test -run Basics ./... will come back with "no tests to run".

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

/remove-lifecycle stale

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

/remove-lifecycle stale

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.