+ in To number is getting removed

Question

+ in To number is getting removed

rrjanbiah opened this issue 3 years ago · comments

R. Rajesh Jeba Anbiah commented 3 years ago

I think, it is due to the encoding. When + is optional for a provider, this issue may not be noticed.

Kailash Nadh · Answer 1 · Wed Mar 17 2021 02:15:36 GMT+0800 (China Standard Time)

Can you provide more details? Are you using the HTTP API or the built in HTML/JS plugin view?

R. Rajesh Jeba Anbiah · Answer 2 · Wed Mar 17 2021 23:03:21 GMT+0800 (China Standard Time)

@knadh Using HTTP API. More specifically, if we print otp.To it is without the + at https://github.com/knadh/otpgateway/blob/master/providers/pinpoint/pinpoint.go#L124 Hope I'm not the only one.

Kailash Nadh · Answer 3 · Thu Mar 18 2021 13:06:03 GMT+0800 (China Standard Time)

Using HTTP API

You've to encode the POST body properly before sending it to the API. HTTP client libs usually do this automatically, unless the request is being prepared manually with string concatenation. OTPGateway will automatically decode the values properly (Go net/http).

R. Rajesh Jeba Anbiah · Answer 4 · Thu Mar 18 2021 19:00:05 GMT+0800 (China Standard Time)

Yes, but couldn't figure it out why otp.To is missing + at https://github.com/knadh/otpgateway/blob/master/providers/pinpoint/pinpoint.go#L124 and so had to append manually there. If anyone else is not facing the issue, please feel free to close this issue.