etcd provider does not support this method

Question

etcd provider does not support this method

lyonnee opened this issue a year ago · comments

lyon.nee commented a year ago

Describe the bug
When I use etcd as provider, I get this error message

To Reproduce

Expected behavior
Can parse my configuration information from etcd

Please provide the following information):

OS: osx
Koanf Version v2.0.0
providers/etcd Version v0.1.1

John Behm · Answer 1 · Fri Apr 07 2023 16:54:21 GMT+0800 (China Standard Time)

nil checking the returned object is pretty bad imo. The Provider function should return a second error value.

This will lead to defensive programming where you start to distrust returned pointer values.

It would be great if you could provide a way to setup a test environment quickly.

lyon.nee · Answer 2 · Mon Apr 10 2023 10:08:22 GMT+0800 (China Standard Time)

@jxsl13
I fully agree with your opinion that judging whether Provider is equal to nil is a very bad approach. I am planning to modify the source code here to initiate PR

lyon.nee · Answer 3 · Thu May 04 2023 13:53:19 GMT+0800 (China Standard Time)

The new PR is here #217