Bump grunt-lib-phantomjs to ^1.0.0

Question

Bump grunt-lib-phantomjs to ^1.0.0

wrumsby opened this issue 8 years ago · comments

This version brings in Phantom 2.1 which provides better support for ES5 features, including Function.prototype.bind which wasn't supported in Phantom 1.9.

Tom commented 8 years ago

+1

Kelly Miyashiro · Answer 1 · Wed Feb 03 2016 06:31:01 GMT+0800 (China Standard Time)

Cool, this will go into the 1.0 release

Burak Yigit Kaya · Answer 2 · Fri Mar 04 2016 19:30:01 GMT+0800 (China Standard Time)

Any news about this or the 1.0 release?

Kelly Miyashiro · Answer 3 · Sat Mar 05 2016 02:30:35 GMT+0800 (China Standard Time)

Hey guys, I have a branch for this here: https://github.com/kmiyashiro/grunt-mocha/tree/bump-phantom

Unfortunately, it's breaking the xunit file output test and I don't have time at the moment to investigate more. If anyone wants to investigate the cause, that would be a big help.

Burak Yigit Kaya · Answer 4 · Sat Mar 05 2016 15:50:03 GMT+0800 (China Standard Time)

@kmiyashiro - thanks for the update! I'm willing to give a hand with this so I'll checkout the branch and see if I can fix it.

Burak Yigit Kaya · Answer 5 · Sat Mar 26 2016 20:37:43 GMT+0800 (China Standard Time)

Okay, I got this working. I had to use latest master instead of the published 1.0.1 version of grunt-phantomjs since it had an important fix that prevented our tests from failing randomly.