km2ii / JVP_TG-PLUS

This is enhanced mod for javplayer, enhance the effect after removing mosaic.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is it necessary to set offset_x and offset_y when using tecoganDA or basicVSR (bvpp)?

teijiIshida opened this issue · comments

Is it necessary to set offset_x and offset_y when using tecoganDA or basicVSR (bvpp)?

commented

These two parameters can be used if the output has an offset.

How do I know if "the output has an offset"? What happen if I just use 0 for both?

commented

Why use this parameter if you are not sure if the image has been offset?

I read it in another forum (ScanLover), so I was wondering if he's correct. Someone said this:

Also using any of the new models require setting offset_x and offset_y in config. I figured out the offset settings. X: subtract 1 means go left, Y: subtract 1 means go up.
-1,-2 offset for basicVSR-pp-st_80000/1650000/af_85000
-3,-4 offset for bvpp-8x / teco-da-8x

So I was wondering if it applies always when using these models or just some video based on certain conditions.

commented

image

The offset issue was fixed in v0.3.03.20, now just keep the parameters.

In fact, it is not that this mod problem, but that the official model has an offset, and the official corrected the offset when compositing images.

The correction is forced to adapt to the official.

Thank you. I will keep both at 0 as instructed.