klinker24 / talon-for-twitter-android

The most powerful and beautiful Twitter client available.

Home Page:https://klinkerapps.com/talon-overview

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

A possible GoogleApiClient leak in 'NotificationCompose'

AICT20 opened this issue · comments

'NotificationCompose' extends 'Compose' and calls its own 'setUpReplyText' method in onCreate.
However, I find that 'finish' method can be called in 'setUpReplyText', which can skip the onStop method according to Android documents. Meanwhile, in 'Compose', GoogleApiClient is required in onCreate while released in onStop, there may be a case that GoogleApiClient is never released when 'finish' is called, isn't it?

Maybe a better solution is to override the 'finish' method and release the GoogleApiClient in it if not.