klinker24 / Android-TextView-LinkBuilder

Insanely easy way to define clickable links within a TextView.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

There is 2 major issues and 1 Imporvment

moali2402 opened this issue · comments

1st Issue :
setHighlightAlpha Doesn't work with Patterns.
The Fix : You missed this.highlightAlpha = link.getHighlightAlpha(); in the Link(Link link) constructor.

2nd Issue: If TextView doesn't have any links that match patterns, it doesn't show any text in the textView.
The Fix: Move this.spannable = SpannableString.valueOf(text); from addLinkToSpan to any method before Build. or to be more precise, any where before turnPatternsToLinks(); method is called in build.

Improvements : Support LinkBuilder Class using String as parameter not TextView.

2 was fixed this morning and your improvement is being discussed here: #3

The first one is now fixed: 7311063