klen / pylama

Code audit tool for python.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pylama command no longer supports multiple paths

datGryphon opened this issue · comments

commented

I tried to search around and confirm that this was not an intentional change before creating this issue:

I'm working in a project with pylama and recently updated from 7.7.1 to 8.3.6. But in the newest version, pylama is not actually linting all of the different paths I provide in the arguments list, only the first path is actually being linted

$ pylama app tests
$ pylama app
$ pylama tests
tests/<redacted>.py:23:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:25:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:2:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:3:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:6:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:7:1 W0611 '<redacted>' imported but unused [pyflakes]
tests/<redacted>.py:13:1 W0611 '<redacted>' imported but unused [pyflakes]

From what I could tell it doesn't look like the syntax of the pylama command itself was modified (based on the output of pylama -h) but for some reason the behavior has changed. Prior to the major-version update, the first command shown successfully returned the linting errors for both the app and tests directories.

I discovered this issue because a project partner of mine had pushed up code containing linting error that he (and the pipeline) hadn't caught because they were already on 8.3.6 while I was on 7.7.1 and we were all using the first command shown above.

commented

I looked more into the issue, and it looks what actually might be happening is that a file level ignore [from inside app/] for W0611 is being picked up and applied to all subsequent files being linted. I will try to work on a minimum reproducible example for you.

@datGryphon Thank you for the report. Please try the latest (8.3.7) version of the pylama.