kkuchera / canalyze-hw

Hardware for a CAN to USB bridge.

Home Page:https://kkuchera.github.io/canalyze/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Include part numbers in circuit schematic, include a BOM and use appropriate diagrams of the hardware components

VoxCodice opened this issue · comments

It would be nice if you could label the schematic parts with the actual product part numbers you used for the PCB. It would avoid confusion and also make it easier to source the parts.
For example, the DIP switches schematic diagram is as follows:
image

According to the diagram, one would assume it is simply a series of 8 SPST switches. Then, looking at the actual picture of the board, one would see that there are only 4 switches and you would think, since the diagram shows SPST switches, that the circuit is equivalent to:
image

One would think that DB9_7 and 3, 2 and 5, 3 and 1 are all connected together which is just wrong. In this case, the switches just interrupt the DB9 port traces. This would result, best case scenario, in the car throwing up errors since the port pins are wired incorrectly.

The only way of telling exactly what sort of switch you used was by looking up the part number from the actual image of the board, which shows a CTS 206-124 DIP switch. Having an actual part number in the diagram or BOM would have made it clearer what that part is. With this in mind the actual diagram should look something like this:
image