kk4das / IC746CAT

ICOM IC-746 Computer Aided Transceiver (CAT) control emulation for Arduino

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

jtdx/wsjtx

k7ilo opened this issue · comments

Library will not connect to jtdx nor wsjtx. Hamlib error. Running the latest versions of both. Library will connect without any issues to Fldigi, Flrig, and Ham Radio Deluxe 5.24.0.38.

Dean
It seems it gets broken after version 2.3.0. I have confirmed this version works with both the Windows and Linux versions if this helps. I have not tried JTDX yet with older versions but i will assume that they are built from the same source code.
Ill try an earlier version to see where it gets broken.

Harold - K7ILO

NP Dean. Take your time. Be careful out there.

The problem looks to me like it's here
default: // For all other commands respond with an ACK
#ifdef DEBUG_CAT
dbg = "unimp cmd: ";
dbg += String(cmdBuf[CAT_IX_CMD], HEX);
catDebug.println(dbg.c_str());
#endif
sendAck();

That needs to be sendNack() -- any unknown commands need to get NAK'd

The problem looks to me like it's here default: // For all other commands respond with an ACK #ifdef DEBUG_CAT dbg = "unimp cmd: "; dbg += String(cmdBuf[CAT_IX_CMD], HEX); catDebug.println(dbg.c_str()); #endif sendAck();

That needs to be sendNack() -- any unknown commands need to get NAK'd

Not sure why I didnt take the plung to try messing with the code with the changes you brought up until now, but its been working for a few hours now for me.

Thanks for finding this.

Harold - K7ILO