App crashes on clicking pause button for download in Landscape mode.
rohap97 opened this issue · comments
Describe the bug
App crashes when we click pause button for download in Landscape mode.
Steps to reproduce the behavior:
- Start Downloading a .zim file
- Go to Downloading tab.
- Rotate the screen to Landscape mode.
- Click the pause button for ongoing download.
- App crashes
Environment
- Version of Kiwix Android : 2.4 Build: 55
- Device : Lenovo Vibe K5 Note
- OS version : Android 6.0
It seems like downloadFragment.listView.invalidateViews();
doesn't know which orientation to move into. I'd like to work on this can anyone guide me? I am sort of a beginner to android.
@MisterAwesome23 The general way to go about fixing something like this is to first reproduce it on a device you have. Then get a stacktrace for it. Using this work out where the code is incorrect and attempt to change it so you no longer crash.
What exactly is stack tracing. I performed the crash and noted the log cat for reason for crash that is from where I got the list view fragment function. Is there better ways to debug/stack trace or log cat is the right way.
I am pretty new to debugging too, any idea how to grap onto debugging quickly, like any course or resources?
@MisterAwesome23 RE stacktracing yeah use you can use logcat. RE debugging its mostly something you just need to practise imo but there might be some good tutorials on Google.
Can I take this up?
@ShridharGoel You can work on it. I think @MisterAwesome23 is not working on this.
I tried to reproduce this today but i couldn't reproduce this.
@abdulwd @shridharghoel can you?
Yes I'm able to reproduce it.
@ShridharGoel Alright. Good Luck.
@iadeelzafar Thanks.
Fixed in #1170