irc-framework mishandles RPL_WHOSPCRPL

[Max Leiter]

cc @SadieCat @PolarizedIons

from IRC:

13:22 <Sadie> what you're supposed to do for whox matching is give it a token (flag t) and then use that token in the response  to work out what parameters the server responded with 
13:24 <Sadie> for the record- inspircds whox implementation was written based on snircd readme.who which has a last edited date of 02 Jan 1999, ircv3s is based on that

---

16:30 <itsonlybinary> tracking the request would be the only way to support custom whox params
16:30 <itsonlybinary> it would also involve parsing outgoing messages and adding them to the event bus

relevant code:

irc-framework/src/commands/handlers/misc.js

Lines 131 to 144 in 469cbe7

 cache.members.push({ 
     nick: params[5], 
     ident: params[2], 
     hostname: params[3], 
     server: params[4], 
     op_level: op_level, 
     real_name: params[10], 
     account: params[8] === '0' ? '' : params[8], 
     away: is_away, 
     num_hops_away: parseInt(params[7], 10), 
     channel: params[1], 
     channel_modes: chan_modes, 
     tags: command.tags 
 }); 

irc-framework/src/client.js

Line 786 in af14f5a

 client.raw('WHO', target, '%cuhsnfdaor'); 

[ItsOnlyBinary]

This issue was resolved with #333