kimbauters / ZIMply

An easy to use offline reader for ZIM files right in your browser!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missising Dependancy (`version2`)

danielbarry opened this issue · comments

A requirement for version2 is zstandard. It's in setup.py but not in the readme.

Also from my experience of version 2 you should look to switch this onto the master branch, it appears quite stable. Great work.

Thanks, fixed the readme.

The reason why the version2 branch is still not merged into the master is because it only updates the core – the part that reads the ZIM file. The frontend, which is the server that you access, needs to receive the same love. This includes some open issues such as your own suggestion in #34 . More importantly, a move away from falcon and gevent and towards a server such as the pure Python cheroot would further improve compatibility and ease of installation. There are some issues with falcon as it had breaking changes between major versions, nor does it support anything earlier than Python 3.5. I am always open to PR requests that would do such a careful rewrite.

I do not currently have the time to do this, and I won't have the time in the next couple of months either. Maybe after that if no one else looks into it ... . I will leave this issue open as a general request to integrate branch version2 into master.