merge erc-image into ERC/Emacs

[Corwin]

Thanks for this lovely feature.

Would you be open to incorporating this package into ERC (and thus Emacs)?

This would require assigning copyright so (if you haven't already), I'm implicitly asking if you would be comfortable with filling out copyright assignment papers with FSF for Emacs.

TIA for consideration.

[Corwin]

Hi again.

Feeling pretty foolish now that I've figured out I'm opening an issue in a fork.
In any case, thank you for providing a maintained version of this.

As this seems to be the source for the package as available from MELPA perhaps the question remains pertinent..

Is seeing this merged to ERC/Emacs something you would be interested in?

Amin Bandali who maintains ERC has expressed willingness to help with that process if it's of interest. You can reach them in email via bandali AT gnu.org (or catch us both in the #ERC channel on libera.chat).

[Raimon Grau]

Hello .Yes! that would be awesome!

I signed my FSF agreement some time ago but it should still be valid.

Even though this is a fork, I've coded the majority of it (we started it with a friend under his user, but I took the ownership of the repo since very early).

Do we have to measure contributions from other people and reach out? or, if I rewrite their code, is it ok? because IIRC there's been just a handful of contributions from others.

[Corwin]

Thanks for the reply! I'm responding via email rather the GH web-ux so I can copy in the ERC list as well as Amin, the maininer. My thoughts are below and I hope Amin will weigh-in as well.

On Fri, Jan 21, 2022 at 1:16 PM Raimon Grau ***@***.***> wrote: Hello .Yes! that would be awesome! I signed my FSF agreement some time ago but it should still be valid.

Agreed, there's not an expiration date on assignment AFAIK :D

Even though this is a fork, I've coded the majority of it (we started it with a friend under his user, but I took the ownership of the repo since very early).

A quick look though the substantial number of commits to your version suggested the same to me- it looks like most of the code is new or rewritten in your version. Do we have to measure contributions from other people and reach out? or, if

I rewrite their code, is it ok? because IIRC there's been just a handful of contributions from others.

In an ideal world I would suggest reaching to each contrib; if everyone has or would be willing to complete the assignment process it may simplify things. Alternately (or if there are some we can't reach or who can't complete the assignment process), I think we would usually essentially count lines of code related to (non-trival) change. IIUC, contributers having 15 or fewer LoC in the project need not assign copyright. That said, that LoC limit is a lifetime total, meaning if a given contrib had 10 LoC in erc-image but already had submitted 10 LoC to something else in Emacs (and had not completed assignment paperwork) that would put them over the limit and we would need their assignment to proceed. If this get's complicated a first step could be adding this into the new Non-GNU ELPA repository. We can add some folks to the thread to discuss that if/when that seems like something to dig into (assuming it sounds good to you). Non-GNU ELPA has the advantage of being available as a default package repository starting with Emacs 28 (now in pre-release testing). Aside: I'm developing a patch for you to consider which is what lead me to reach out. I'll make a new issue on GH to discuss that. (FTR, I do have assignment completed ;) Thanks again for your response and for erc-image; looking forward to seeing this great feature get wider reach. Corwin

[Raimon Grau]

Ok, let's ping all contributors while we figure out the next steps:

Hi everyone, we're trying to gather info about who's willing to sign the copyright assignment to merge this code into emacs source tree.

If you have it already signed, just answer this thread and I'll update the list. Otherwise, if you're willing to sign it now, you should send an e-mail to [e-mail]. Tell them either that you'd like to sign a copyright assignment for contributions to erc-image.el to be included in future versions of Emacs; or say that you'd like to sign a general assignment form for any future contributions to Emacs. They will send you the PDF that you need to sign and return to them.

If you have questions regarding the process, you might find some answers in this use-package.el thread

• @kidd
• @cofi
• @davazp
• @jondeandres
• @Miciah
• @rbistolfi -- under 15 lines
• @mrvdb
• @seanfarley -- not willing to sign, but only whitespace changes
• @areina -- under 15 lines
• @pao -- under 15 lines
• @tarsius -- under 15 lines
• @titanofold
• @aterweele -- under 15 lines

Thanks everyone!

[Sean Farley]

Sorry but I refuse to assign any copyright over to the FSF until RMS is removed permanently (along with his commit access to Emacs).

[Raimon Grau]

@seanfarley , thanks for your quick answer. I totally respect your decision.

Looking more in detail though, it seems that you contributed only whitespace, so I guess we can do without your signature.

https://github.com/kidd/erc-image.el/commits?author=seanfarley

[Jonas Bernoulli]

@tarsius -- under 15 lines

As in removing a single character. 😀
Yes, please go ahead and add this to Emacs.

[Aaron W. Swenson]

I'm up for signing the copyright assignment. I'll contact them shortly.

[Miciah Dashiel Butler Masters]

I am fine with assigning copyright for my changes to erc-image.el to the FSF.