khoren93 / SwiftHub

GitHub iOS client in RxSwift and MVVM-C clean architecture

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Firebase plist in repo

DanBurkhardt opened this issue · comments

Hey just want to let you know that your Firebase plist is included in your Repo. Not sure if you have anything critical in there but it could be exposing any DB contents you have or access to your services. Thanks for contributing this great work, looking forward to playing around with it.

Hi @DanBurkhardt

I created two Firebase applications, one for developmet and one for App Store.
The project also contains keys for these services which will also be replaced in the release.

enum Keys {
    case github, mixpanel, adMob
}

#11
Thanks :)

Reading this on a locally built/run version right now! Thanks man.