/close does not close the config portal
marcelstoer opened this issue · comments
I'm using Async_ConfigOnSwitch (1.1.2) unchanged on ESP32.
When I click "Exit Portal" (i.e. request /close
) the WiFi Manager remains in config mode until timeout is reached. This is unexpected to me. I expected the config portal to close and for the WiFi Manager to go back to station mode.
In order to exit the config portal I have to hit "Configuration" and then "Save" without entering any values.
Does this work as designed?
Can you un-comment this Line 1715 from
//stopConfigPortal = true; //signal ready to shutdown config portal //KH crash if use this ???
to
stopConfigPortal = true; //signal ready to shutdown config portal //KH crash if use this ???
to see if that is what you expect.
Possibly I forgot to un-comment after tested last time.
Indeed, that's the behavior I would expect. Thanks! In fact, on iOS the config portal window/dialog closes so quickly now that you don't even get to see the /close
response "page". Not that I would care about it anyway 😄 Important is that the portal is shut down and that works nicely now.
That's good. Will update in next release.
Can I ask you to keep issues open until the respective fix has landed on master
? That would allow us to be notified by GitHub when we can update our dependencies.
Master updated.
See ESP_WiFiManager v1.2.0 and Contributions-and-Thanks
Releases v1.2.0
- Restore cpp code besides Impl.h code to use in case of
multiple definition
linker error. SeeChange Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h
andSupport building in PlatformIO PR
. Also have a look at HOWTO Fix Multiple Definitions Linker Error - Fix bug /close does not close the config portal.