Unable to build with custom erl-bin directory [PATCH]
tisba opened this issue · comments
$ pwd
/Users/basti/Documents/src/Pillow
$ which erl
/usr/local/bin/erl
$ ERL="/usr/local/bin" ./configure --prefix=/Users/basti/Documents/src/Pillow/dev
# ..... successful, no errors
$ make && make install
# ..... successful, no errors
$ ./dev/bin/pillow
./dev/bin/pillow: line 250: /usr/bin/erl: No such file or directory
Not sure if I'm doing something wrong here or if this is a bug.
Looks like /usr/bin/erl is hardcoded in bin/pillow.tpl.in. Patch to fix this here: http://gist.github.com/489646
It's probably a bug. Looking into it now
The path to the erlang binary was hardcoded. I have tagged PUBLIC_0_3_3 now with a correction. You still need to specify ERL="/usr/local/bin/erl" or similar with the full path including command to use custom binary.
uh, you are right, I just provided the path and I got that wrong in my patch.
But still, I think you missed a spot in the pillow.tpl.in. in the function remote_command you are also invoking erl without the path. Shouldn't this be set to the same path to ensure that the same erl command is being used?
Doh. I even search for more similar issues. Fixing.
:-)
Fixed in PUBLIC_0_3_4. Corrected to the environment variable again. The erl without a path was an uglier omission.