$$VERSION$$ in example yaml possibly not resolved

Question

$$VERSION$$ in example yaml possibly not resolved

andreas-ibm opened this issue 10 months ago · comments

Describe the bug

I'm no k8s expert, let's start with that!

I have a script that effectively follows https://www.keycloak.org/getting-started/getting-started-kube, so at one stage it runs:

kubectl create -f https://raw.githubusercontent.com/keycloak/keycloak-quickstarts/latest/kubernetes/keycloak.yaml

which used to work fine, but since #458 and #459 it doesn't...

If I manually download the yaml and replace $$VERSION$$ with the latest version it works again, so I'm pretty sure it's the cause.

Is there meant to be some magic that I'm missing? I can obviously put some sed magic in my script to do the replacement, but I'd suggest the above getting-started page would need improving to tell users they need to perform the substitution.

Version

22.0.1

Expected behavior

Keycloak up and running

Actual behavior

Got this error:

Events:
  Type     Reason         Age                   From               Message
  ----     ------         ----                  ----               -------
  Normal   Scheduled      17m                   default-scheduler  Successfully assigned default/keycloak-794869df8-trspp to worker-3
  Warning  Failed         15m (x12 over 17m)    kubelet            Error: InvalidImageName
  Warning  InspectFailed  2m51s (x72 over 17m)  kubelet            Failed to apply default image tag "quay.io/keycloak/keycloak:$$VERSION$$": couldn't parse image reference "quay.io/keycloak/keycloak:$$VERSION$$": invalid reference format

How to Reproduce?

Follow instruction on https://www.keycloak.org/getting-started/getting-started-kube

Anything else?

No response

Václav Muzikář · Answer 1 · Tue Aug 01 2023 23:55:39 GMT+0800 (China Standard Time)

@andreas-ibm Thanks for the report. This indeed seems like a bug.

Domenic Gosein · Answer 2 · Fri Aug 18 2023 23:39:01 GMT+0800 (China Standard Time)

I have just encountered the same problem. Would it make sense to use a specific tag again in this manifest, or update the documentation to let users know that they need to change the version tag before applying?

Stian Thorgersen · Answer 3 · Fri Sep 15 2023 17:37:21 GMT+0800 (China Standard Time)

Fixed the script + updated the latest branch to now point to 22.0.3

Andreas Martens · Answer 4 · Fri Sep 29 2023 23:40:58 GMT+0800 (China Standard Time)

Cool, confirmed fixed

Dessa Simpson · Answer 5 · Thu Nov 16 2023 02:21:36 GMT+0800 (China Standard Time)

The script seems to be broken again, as I just hit this issue trying to deploy Keycloak based on the getting started guide.

Václav Muzikář · Answer 6 · Thu Nov 16 2023 15:59:31 GMT+0800 (China Standard Time)

@virtualdxs Should be fixed in #504, it will be part of the next release.