keybase / triplesec

Triple Security for the browser and Node.js

Home Page:https://keybase.io/triplesec

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

too many comments?

alchmy opened this issue · comments

I love what you are doing here, and am trying to grok the source so that I know how to use parts of the library for a project of my own. I am wondering about the code style, is it really necessary to include all the extra comments and versioning information ? Isn't the purpose of git to handle versioning?

https://github.com/keybase/triplesec/blob/master/src/enc.iced

There are comments in the code so that others can understand the code easier.

As for the versions, there are actually (currently) four different versions of the TripleSec format. The current implementation needs to be able to decrypt messages from previous versions.