kevva / bin-wrapper

Binary wrapper that makes your programs seamlessly available as local dependencies

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Do not search globally for binaries.

Ackar opened this issue · comments

Commit 85a9d04 removed the global option (not totally though...) breaking at least mozjpeg-bin (see this pull request).

Maybe the module should not search for pre-installed binaries? I think this can cause some trouble if a different version or a different binary with the same name (mozjpeg) is already installed on the system.

We're using version checks to ensure that the binary meets the desired version. Unfortunately mozjpeg (jpegtran) doesn't exit when checking version so we're unable to utilize that. Global checking will be a little buggy until I've rewritten https://github.com/kevva/find-file.

However, I don't think we should remove checking for pre-installed binaries since we know that they works.

Should be fixed now.