Support for 'signed-off' commits

Question

Support for 'signed-off' commits

dam0vm3nt opened this issue 7 years ago · comments

Vittorio Ballestra commented 7 years ago

When trying to "parse" signed-off a commit log and exception is thrown:

Caught error Bad state: No element
dart:core                                                                                            Iterable.single
package:git/src/commit.dart 59                                                                       Commit._parse

Stargator · Answer 1 · Thu Jul 11 2019 23:57:42 GMT+0800 (China Standard Time)

@kevmoo If this is fixed, this can be closed, right?

Kevin Moore · Answer 2 · Fri Jul 12 2019 00:11:43 GMT+0800 (China Standard Time)

I have no idea if this is fixed. Does it work for you?

Stargator · Answer 3 · Fri Jul 12 2019 00:59:28 GMT+0800 (China Standard Time)

Oh nevermind, I thought b29bef7 was your commit

Kevin Moore · Answer 4 · Fri Jul 12 2019 02:36:24 GMT+0800 (China Standard Time)

It is! looks like it's in!

…

On Thu, Jul 11, 2019 at 9:59 AM Stargator ***@***.***> wrote: Oh nevermind, I thought b29bef7 <b29bef7> was your commit — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AAAEFCXOUPOUVP3HALYNRL3P65RHBA5CNFSM4DYRYTZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXKXQY#issuecomment-510569411>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAEFCSUDQ6BAZKKIUPQ2LTP65RHBANCNFSM4DYRYTZQ> .

Kevin Moore · Answer 5 · Fri Jul 12 2019 02:36:29 GMT+0800 (China Standard Time)

Wonder why this didn't get closed then. Weird!

Fixed in b29bef7

Stargator · Answer 6 · Fri Jul 12 2019 09:01:29 GMT+0800 (China Standard Time)

@kevmoo I'm sorry for the confusion I caused, but I don't think b29bef7 was merged into the repo.

TL/DR: This should remain open and @dam0vm3nt should create a PR with the commit referenced based on the changes to that file. Or I will cause I caused this confusion today.

Longer version:
It was committed to a fork and I looked through all the commits since August 2017 in this repo and nothing seems to merge in that change.

When I type in that hash (as seen at the top of this post), it looks like it's in this repo, but it's not listed as in any branch. But this link dam0vm3nt@b29bef7 points to where the commit currently resides. In a forked repo.

@kevmoo I'm sorry I inadvertently misled you or confused you.