kermitt2 / entity-fishing

A machine learning tool for fishing entities

Home Page:http://nerd.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

More metatadata in the JSON response

kermitt2 opened this issue · comments

Add in the JSON response a bit more metadata consistent with other tools:

{ 
...
  "software": "entity-fishing",
  "version": "0.0.4",
   "date": "2018-05-02T12:24:55.529301",
...
}
(date is the date of generation of the response)

Hello @kermitt2 ,

I implemented methods regarding this issue in a branch metadataJSON. Below is the result, what do you think?

screen shot 2018-10-18 at 17 54 02

I add here, as mentioned in f30ea39#commitcomment-30958982, we should add also an entry point in the API /version returning the version number (and the name, since we have also the name)

An entry point /version in the API returning the name, the version number and the description has been added in the same branch metadataJSON.

screen shot 2018-10-19 at 13 40 54

Thanks for the input @lfoppiano . All the fixes has been done in the same branches. I will make the pull request if everything is OK.