kenhub / giraffe

Giraffe - a graphite dashboard with a long neck

Home Page:http://giraffe.kenhub.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Show axis labels outside of the graph

SEJeff opened this issue · comments

here is an example from the rickshaw docs

Nice idea, but rickshaw doesn't make it super-easy to use. Seems to require jumping through a bit of css hoops, setting another div for the y-axis, ensuring it glues well together etc... not sure if this is very high priority at the moment, but definitely doable. Would be happy to accept a pull request if you feel like implementing this.

If I were to take a stab at doing it, how would you want it implemented? I think it makes sense to be a default honestly as it is really hard to see the scale for some of the graphs with the numbers inside of the graph themselves.

I already grabbed @nhapke to help out, but he's a little busy, so I'm not sure when we'll be able to get down to it.

If you want to try things out, I can create a branch with the basic html / code to add this option, and you can try to edit the css to make this fit in the right place (I believe all it takes is some css tweaks). How does that sound?

@SEJeff I've created a new branch y_axis with the scaffolding of the change based on the Rickshaw page and documentation. If you can edit the CSS file (main.css is probably the best place) so it fits nicely then it could be really great.

Please note that you'd have to deal with graphs spanning 1,2 or 3 columns. Also I believe you'd have to use your own dashboards.js since it will only affect the real graph, not the demo version...

If you manage this, then please make a pull request into the y_axis branch with your changes.

Why can't more upstream maintainers be awesome like you? Also... I noticed there is no #kenhub IRC chatroom on freenode. If you're on IRC, I'd love to throw some ideas your way (if that is ok with you).

sorry, not really on IRC (last time I used it was around 1994 and even then I found it rather confusing...).

feel free to drop me an email to yoav at kenhub dot com

From what I tried it's not as easy as it might seem, especially for graphs that might have different dimensions. But I want to take a look at the latest Rickshaw and perhaps this will help making things easier to tweak. For the time being however I'll close this. Feel free to re-open or submit a pull request if you find a nice and easy way to do this though.